• src/xpdev/dirwrap.c

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, January 20, 2024 14:29:14
    https://gitlab.synchro.net/main/sbbs/-/commit/d9d140af60f18552e07150de
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Fix disksize/space functions for Win32

    Broken 11 months ago with commit ae44ab15: the unit argument was ignored (e.g. converting to kibibytes) and the free/total disk size/space checks were reversed.

    Reported by Max (WESTLINE) via usage of JS properties: system.freediskspace and system.freediskspacek.

    The JS global functions dir_freespace() and disk_size() were also broken due to this bug.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sunday, January 21, 2024 14:28:18
    https://gitlab.synchro.net/main/sbbs/-/commit/095858e5c974d1e6265f0b65
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Set size to MAX_PATH+1 when allocating.

    On Win32, size is explcitly "ignored" when target is NULL, so we
    should set it to the size of the allocation.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, February 24, 2024 08:40:35
    https://gitlab.synchro.net/main/sbbs/-/commit/cb0dbdaf0928ea962e5b8c9d
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Fix glob() for Win64

    _fintfirst() is declared in the Mingw-w64 headers as an intptr_t,
    which tracks. Can't find _findfirst on MSDN, so that's good enough
    for me... let's see what the pipeline says.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Monday, April 29, 2024 22:02:01
    https://gitlab.synchro.net/main/sbbs/-/commit/bf757d6952f7ac30b9f0c819
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Not every platform has GLOB_ONLYDIR support

    ... kind of as I suspected

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, December 06, 2024 13:17:19
    https://gitlab.synchro.net/main/sbbs/-/commit/abac966eec71a2f3af83ae6c
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Optimize mkpath()

    If the path already exists (is a directory), don't need to check each path element for existence.

    This should help with the speed of saving of large file.ini (Nelgin's) when a lot of directories have "Check for File Existence" set to "Yes".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, December 10, 2024 16:27:55
    https://gitlab.synchro.net/main/sbbs/-/commit/5e025ef3f92105834d4c7178
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Fix bug in recursive use of delfiles(), not deleting all subdirs/files

    Looks like this feature (commit d661427e13) never really worked correctly
    since it counted the files removed from each sub-dir and then stopped deleting when the count reached the number of files in the base directory. This was
    done to accommodate the 'keep' feature (part of previous commits).
    So make 'keep' check conditional on it being non-zero and just don't ever use
    a non-zero keep value with a recursive delete and we should be good! :-)

    This fixes issue #841

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, December 21, 2024 22:58:59
    https://gitlab.synchro.net/main/sbbs/-/commit/c82eff12b58be6dca245c599
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Comment out access() call in Windows version of getfilecase()

    I'm hoping this might help resolve instances where fexistcase() says a file does not exist, but a subsequent call to fexist() says it does.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, December 22, 2024 00:50:13
    https://gitlab.synchro.net/main/sbbs/-/commit/e7cfae3e9ad94036156dd0ba
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    A little style clean-up, reduced copy/paste, no functional changes

    Reduce the cognitive dissonance

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Wednesday, January 15, 2025 22:32:42
    https://gitlab.synchro.net/main/sbbs/-/commit/33be8662a0d67a0ced7f0658
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Add some temporary debug output to find the mac mini m4 hang

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Wednesday, January 15, 2025 23:04:56
    https://gitlab.synchro.net/main/sbbs/-/commit/41169123a99ebff32f28720c
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Revert "Add some temporary debug output to find the mac mini m4 hang"

    This reverts commit 33be8662a0d67a0ced7f06587fdec01a27b818a8.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, February 04, 2025 21:25:43
    https://gitlab.synchro.net/main/sbbs/-/commit/dfef8a98c12122a8d7441561
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Remove pre-WinXP support from getdiskspace()

    No need to use LoadLibrary and GetProcessAddress here any more either

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, February 08, 2025 13:21:24
    https://gitlab.synchro.net/main/sbbs/-/commit/f1f7b121785f300b994927ef
    Modified Files:
    src/xpdev/dirwrap.c
    Log Message:
    Use strlcpy instead of sprintf("%.*s") string truncation trick

    Resolves MSVC x64 build warnings.

    Also fixes a bug with wrong sizeof argument used in readdir() (!)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net