src/sbbs3 main.cpp 1.741 1.742
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3304

Modified Files:
main.cpp
Log Message:
Added new semfile to clear the failed login attempt list: "ctrl/clear"
So now if you need to clear the failed-login/temp-ban list, just
'touch /sbbs/ctrl/clear'
Other changes to the semfiles:
The terminal server is now identified as "term" rather than "telnet" in the (optional) server/protocol specific semfile naming.
Removed support for the old telnet.rec semfile (long deprecated).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.749 1.750
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16111

Modified Files:
main.cpp
Log Message:
New cryptlib uses 345 not 3450.
*sigh*



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.757 1.758
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22730

Modified Files:
main.cpp
Log Message:
Accept and store the "Internet host number" portion of the telnet
TERMINAL LOCATION NUMBER (RFC 946) in sbbs_t::telnet_location.

Some (older?) versions of fTelnet request to send this option to the BBS to share the real IP address of the client. Accept this option (when using
"format 0") and store the first 32-bits (an IPv4 address) in the telnet location storage / caller-ID information. The same place the telnet
SEND LOCATION value is stored if received.

Now, we're not requesting this option (e.g. with a Telnet "DO" command), but fTelnet doesn't need that: It offers to send it, so we accept.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.758 1.759
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17377

Modified Files:
main.cpp
Log Message:
Log the length of received telnet sub-negotiation commands (in bytes).
Only retain the last (most recent) 10 data/<id>.qwk.*.bad files and data/file/<user-num>.rep.*.bad files.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.765 1.766
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27823

Modified Files:
main.cpp
Log Message:
Re-enable socket optoins and blocking configuration for the client_socket_dup when de-activating the passthru_socket.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.766 1.767
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4564

Modified Files:
main.cpp
Log Message:
passthru_socket():
Always call recv() when select() says the passthru_socket is readable, even
if the outbuf is full. This resolves an issue where the disconnection of the passthru_socket would not be detected if the outbuf was full (e.g. the output_thread stopped running).
Also, check if RingBufWrite() returns a short-write count and log the values (actual versus expected write byte count).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.767 1.768
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14985

Modified Files:
main.cpp
Log Message:
Log value of 'writable' in "could not write to passthru socket" log msg.
May help determine if the socket is disconnected or just not writable.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.768 1.769
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
main.cpp
Log Message:
Resolve a couple harmless GCC warnings.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.769 1.770
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28680

Modified Files:
main.cpp
Log Message:
When the passthru_thread terminates, set passthru_socket_active to false.
This resolves the issue where if an external program closes the client_socket_dup, the passthru_thread can't write to the passthru_socket,
so it terminates itself - by definition, deactivating the passthru_socket, but it didn't clear passthru_socket_active, so the input_thread would keep trying to write to it rather than sending the input from the user to the BBS.

Also, terminate the passthru_thread (without any special log message) when sbbs->online is non-zero.

Also overhauled a lot of the passthru-related log messages. Passthru ain't just for SSH anymore.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.770 1.771
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21353

Modified Files:
main.cpp
Log Message:
Leave room for telnet IAC expansion (as much as 100%) in the outbuf.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.771 1.772
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12576

Modified Files:
main.cpp
Log Message:
Eliminate call to inet_ntop() which is apparently not present in WinXP:
The procedure entry point inet_ntop could not be located in dynamic link library ws2_32.dll


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

El 28/8/19 a las 23:23, rswindell escribió:

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.

---

i notice that have several *.bad packets at my data dir.


-rw------- 1 root root 6807 ago 16 03:47 VERT.qwk.5d5a512f.bad
-rw------- 1 root root 7898 ago 13 19:47 VERT.qwk.5d5a5944.bad
-rw------- 1 root root 7245 ago 14 14:47 VERT.qwk.5d5a59bc.bad

i rename to vert.qwk to reprocess it, and say that all message are dupe.
Then, i think that was process and import messages fine.

is this commit related to this issue?


Aug 29 10:24:45 localhost synchronet: evnt Inbound QWK Packet detected: /sbbs/data/VERT.qwk
Aug 29 10:24:45 localhost synchronet: evnt QNET Executing external:
unzip -o -j /sbbs/data/VERT.qwk * -d /sbbs/temp/event/
Aug 29 10:24:45 localhost synchronet: evnt QNET Reading /sbbs/temp/event/HEADERS.DAT
Aug 29 10:24:45 localhost synchronet: evnt QNET Reading /sbbs/temp/event/VOTING.DAT
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK Network Packet: /sbbs/data/VERT.qwk
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Discussion
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564377.6017.sync@vert.synchro.net> found in message #36400
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message #36401
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message #36401
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564039.40573.dove_sync@digitaldistortionbbs.com> found in message #36402
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D5633E8.3542.dove-syncdisc@bbs.leenooks.net> found in
message #36403
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564ECC.6022.sync@vert.synchro.net> found in message #36404
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Programming (C/C++ and CVS)
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D56516D.39346.syncprog@cvsuser> found in message #21047
Aug 29 10:24:45 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Data
Aug 29 10:24:45 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564BFC.177089.syncdata@vert.synchro.net> found in message
#13539
Aug 29 10:24:45 localhost synchronet: evnt Finished Importing QWK
Network Packet from VERT: (0 msgs) in 1 seconds (0 msgs/sec), 1 errors,
8 dupes
Aug 29 10:24:45 localhost synchronet: evnt QNET /sbbs/data/VERT.qwk
renamed to /sbbs/data/VERT.qwk.5d67d21d.bad
Aug 29 10:24:45 localhost synchronet: evnt QNET !ERROR 2 (No such file
or directory) in main.cpp line 2876 (event_thread) removing "/sbbs/data/VERT.qwk" access=0



thanks!!

---
þ Synchronet þ Dock Sud BBS TLD 24 HS - http://bbs.docksud.com.ar - telnet://bbs.docksud.com.ar

Re: Re: src/sbbs3/main.cpp
By: Ragnarok to rswindell on Thu Aug 29 2019 11:07 am

El 28/8/19 a las 23:23, rswindell escribió:

src/sbbs3 main.cpp 1.772 1.773
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20280

Modified Files:
main.cpp
Log Message:
Don't try to remove a bad .QWK packet if it's been renamed to *.bad.

---

i notice that have several *.bad packets at my data dir.

-rw------- 1 root root 6807 ago 16 03:47 VERT.qwk.5d5a512f.bad -rw------- 1 root root 7898 ago 13 19:47 VERT.qwk.5d5a5944.bad -rw------- 1 root root 7245 ago 14 14:47 VERT.qwk.5d5a59bc.bad

i rename to vert.qwk to reprocess it, and say that all message are dupe. Then, i think that was process and import messages fine.

is this commit related to this issue?

The commit fixes this error:

Aug 29 10:24:45 localhost synchronet: evnt QNET !ERROR 2 (No such file
or directory) in main.cpp line 2876 (event_thread) removing "/sbbs/data/VERT.qwk" access=0

digital man

This Is Spinal Tap quote #37:
David St. Hubbins: We are Spinal Tap from the UK - you must be the USA!
Norco, CA WX: 92.1øF, 42.0% humidity, 4 mph NE wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

i enable debug:, the "QWK vote failure, offset 6144 in
/sbbs/data/VERT.qwk" appear:


Aug 29 23:54:29 localhost synchronet: evnt Inbound QWK Packet detected: /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt QNET Executing external:
unzip -o -j /sbbs/data/VERT.qwk * -d /sbbs/temp/event/
Aug 29 23:54:29 localhost synchronet: evnt QNET Reading /sbbs/temp/event/HEADERS.DAT
Aug 29 23:54:29 localhost synchronet: evnt QNET Reading /sbbs/temp/event/VOTING.DAT
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK Network Packet: /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Discussion
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564377.6017.sync@vert.synchro.net> found in message #36400
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message
#36401
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D563EDE.40572.dove_sync@digitaldistortionbbs.com> found in message
#36401
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564039.40573.dove_sync@digitaldistortionbbs.com> found in message
#36402
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D5633E8.3542.dove-syncdisc@bbs.leenooks.net> found in
message #364
03
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564ECC.6022.sync@vert.synchro.net> found in message #36404
Aug 29 23:54:29 localhost synchronet: evnt QNET Duplicate vote-msg from VERT Aug 29 23:54:29 localhost synchronet: evnt QNET QWK vote failure, offset
6144 in /sbbs/data/VERT.qwk
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Programming (C/C++ and CVS)
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D56516D.39346.syncprog@cvsuser> found in message #21047
Aug 29 23:54:29 localhost synchronet: evnt Importing QWK messages from
VERT into DOVE-Net Synchronet Data
Aug 29 23:54:29 localhost synchronet: evnt QNET !smb_addmsg duplicate Message-ID: <5D564BFC.177089.syncdata@vert.synchro.net> found in message
#13539
Aug 29 23:54:29 localhost synchronet: evnt Finished Importing QWK
Network Packet from VERT: (0 msgs) in 1 seconds (0 msgs/sec), 1 errors,
8 dupes
Aug 29 23:54:29 localhost synchronet: evnt QNET /sbbs/data/VERT.qwk
renamed to /sbbs/data/VERT.qwk.5d688fe5.bad

---
þ Synchronet þ Dock Sud BBS TLD 24 HS - http://bbs.docksud.com.ar - telnet://bbs.docksud.com.ar

src/sbbs3 main.cpp 1.773 1.774
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22798

Modified Files:
main.cpp
Log Message:
Log (debug-level) interesting sizeof() values during initialization, debug-builds only.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.774 1.775
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15235

Modified Files:
main.cpp
Log Message:
Received-telnet command improvements:
- If a telnet command was received in multiple packets, the memcpy optimization
in telnet_interpret() would skip/drop all bytes in the subsequent pkt payload
before an IAC char. Don't optimize when in the middle of a telnet command.
- If a received telnet command exceeds the telnet_cmd buffer, reset the
received telnet_cmdlen and log a warning-level message
- If a telnet sub-negotiation END command is received as the beginning of a
new telnet command, log a warning-level message and reset the telnet_cmdlen.

This fixes the occasional problem observed when using fTelnet and its sending the "SEND-LOCATION" sub-neg command split between 2 TCP packets. Only
part of the first packet would be used as the location data and the rest processed as input from the users (e.g. as the Login: prompt). Thanks, Ree!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.775 1.776
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18524

Modified Files:
main.cpp
Log Message:
This change goes with the previous commit to scfglib2.c (with no commit msg): Address problem reported by Mark Lewis:
If a timed event is configured to both run "exclusively" and on "Any" node, then any nodes in use at the time of the event would get their status changed to waiting-for-connection (WFC) and it could actually become possible for 2 clients to be using the same node number.
So, when loading the configuration, turn off the "exclusive" flag if the event's node is set to "Any" (0).
Just for completeness, fix the actual bug (introduced in main.cpp 1.744) too.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.777 1.778
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10703

Modified Files:
main.cpp
Log Message:
Fix feature added in rev 1.759 (wrong path argument to delfiles):
Only retain the last (most recent) 10 data/<id>.qwk.*.bad files and data/file/<user-num>.rep.*.bad files.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 main.cpp 1.778 1.779
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12537

Modified Files:
main.cpp
Log Message:
The log msg "passthru socket listening on port n" was always wrong
(said port 0) since the port had not been bound yet.
So fix the display order of that msg (after listen() is called)
and lower the log level to debug.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
Modified Files:
src/sbbs3/main.cpp
Log Message:
request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/277855436d2143b88bd9a501
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/26886a8c7ba879f2e84d2650
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net