src/sbbs3 js_global.c 1.377 1.378
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25955

Modified Files:
js_global.c
Log Message:
Add missing comma to JSDOC line


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.380 1.381
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20279

Modified Files:
js_global.c
Log Message:
html_decode() - add support for the following HTML 4 entities:
- "lsaquo" and "rsaquo" (angled versions of "lsquo" and "rsquo")
- "zwj" and "znnj" (zero-width joiner / non-joiner)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.381 1.382
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
js_global.c
Log Message:
Added todo comment about require() behavior which is unexpected when the passesd filename is not found - function reports the symbol was not
defined rather than file not found or something similar.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.382 1.383
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
js_global.c
Log Message:
Fix require(): if load() fails with exception, don't report a "symbol
not defined" exception, just report the load() exception - whatever it was (e.g. could not open load-file).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.384 1.385
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9081

Modified Files:
js_global.c
Log Message:
New JS global method: file_chmod(), changes a file's mode value ala *nix chmod. Really only useful on *nix since Windows only allows the setting/clearing of
a single mode flag: user-writeable, 0x80, 0200.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.385 1.386
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26683

Modified Files:
js_global.c
Log Message:
New global JS function: file_mode()

This function behaves the same as file_attrib() on *nix, but on Windows, file_mode() returns a *nix/stat style st_mode value (compatible with file_chmod) while file_attrib() returns the struct _finddata_t 'attrib' value, which is a quite different value (e.g. indicates Windows/DOS centric file attributes like "archive", "hidden", etc.) and is *incompatible* with file_chmod(). So if you're going to modify a file's permissions (mode), use file_mode() to read them and file_chmod() to save them.

file_attrib() should really only be used on Windows and only for checking for attributes like "hidden", "archive", etc. (which don't exist on *nix).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.386 1.387
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21380

Modified Files:
js_global.c
Log Message:
Make it clear, hopefully, that resolve_ip() can only return an array upon success. Upon failure to resolve, resolve_ip() returns null.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.387 1.388
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
js_global.c
Log Message:
Debug-level log message when invoking a background-load()
Fixed typo in other log msg.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.390 1.391
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20669

Modified Files:
js_global.c
Log Message:
New global function: utf8_width()
- returns the fixed printed-width of the specified UTF-8 encoded string


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.391 1.392
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25850

Modified Files:
js_global.c
Log Message:
Search the current scope for the js object to locate the current scope in,
not the global scope. This appears to be a systemic issue, and could even
be the root cause of the background log problem...



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.392 1.393
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8511

Modified Files:
js_global.c
Log Message:
Search for the js and log objects in the current scope, not in the global object.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.393 1.394
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17159

Modified Files:
js_global.c
Log Message:
Check the object scope after checking the current scope when looking for
the "js" object.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.394 1.395
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17443

Modified Files:
js_global.c
Log Message:
Also check the object scope for the log function.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.395 1.396
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3811

Modified Files:
js_global.c
Log Message:
Don't leave a pending exception on exit from js_global_resolve().



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.396 1.397
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10351

Modified Files:
js_global.c
Log Message:
Renaned utf8_width() to utf8_get_width()
New global functions:
- str_is_utf8()
- str_is_ascii()
- str_has_ctrl()

Return a more sensible value when 'null' is passed to the utf8_* functions. Updated some JSDOCS strings in regards to "extended-ASCII" and what that
means (in some cases, specifically CP437, in others, any non-ASCII chars).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.397 1.398
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1603

Modified Files:
js_global.c
Log Message:
New global JS function: str_is_utf16(), returns true if the passed string contains one or more UTF-16 encoded characters.

utf8_encode() can now accept a UTF-16 encoded string (e.g. "\u0f00") and will return the UTF-8 encoded version.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.398 1.399
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3090

Modified Files:
js_global.c
Log Message:
Add an additional for of socket_select() that is passed multiple arrays.
It will return an object with properties corresponding to the passed
arrays, and the write parameter will be ignored. This allows usage very
much like the select() syscall, and allows a traditional non-blocking
server to be written.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.399 1.400
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv489

Modified Files:
js_global.c
Log Message:
Fix single-array socket_select broken in previous commit.
This should fix the crash in ircd.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.400 1.401
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29158

Modified Files:
js_global.c
Log Message:
Do not re-create the result arrays for each socket that's read (derp).
This only impacts the new socket_select() method with multiple arrays.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.401 1.402
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28762

Modified Files:
js_global.c
Log Message:
Fix resource leak from background-load()'s:
The created message queue for each background-load()ed script was never detached-from by the child thread, so the linked-lists (and their semaphores) were never freed. Calling msgQueueDetach() before ending the background_thread fixes that leak.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

On 2019 Sep 18 23:52:20, you wrote to CVS commit:

src/sbbs3 js_global.c 1.401 1.402
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28762

Modified Files:
js_global.c
Log Message:
Fix resource leak from background-load()'s:
The created message queue for each background-load()ed script was never detached-from by the child thread, so the linked-lists (and their semaphores) were never freed. Calling msgQueueDetach() before ending the background_thread fixes that leak.

so did my questioning about the background loading of dnshelper.js assist in finding this problem?? if so, YAY!

the main thing that triggered my thoughts on it, which i think i also asked about, was about using load vs require... i was thinking about other recent changes that switched from load to require to prevent multiple loadings of the same code which was also leading to problems of some sort...

in any case, this looks like it was a deep dig to root out... GoodJob!<tm> :)

)\/(ark

Once men turned their thinking over to machines in the hope that this would set
them free. But that only permitted other men with machines to enslave them.
... People who pun deserve to be drawn and quoted.
---
* Origin: (1:3634/12.73)
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/js_global.c
By: mark lewis to rswindell on Fri Sep 20 2019 09:19 pm

so did my questioning about the background loading of dnshelper.js assist in finding this problem?? if so, YAY!

I don't recall that being discussed. It just a shot in the dark that lead to some clues.

digital man

Synchronet/BBS Terminology Definition #31:
FTP = File Transfer Protocol
Norco, CA WX: 63.0øF, 86.0% humidity, 0 mph SSW wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/js_global.c
By: Digital Man to mark lewis on Sat Sep 21 2019 02:02:14

so did my questioning about the background loading of dnshelper.js assist in finding this problem?? if so, YAY!

I don't recall that being discussed. It just a shot in the dark that lead to some clues.

yeah, sorry, that was with my other account, wkitty42, on IRC on the 15th...

double spaced to try to prevent word wrapping from making dog's breakfast out of it... time stamps are UTC-0400...

----- snip -----

Sep 15 10:04:20 <wkitty42> why is dnshelper.js loaded by ircd.js multiple times? should it be "required" so it is loaded once and used for all? could this be one of the leaks being seen?

Sep 15 10:04:21 <wkitty42> Routing: from sestar.synchro.net: Received SQUIT *.synchro.net from wkitty42[wkitty42@sestar.synchro.net] (wkitty42)

Sep 15 10:04:21 <wkitty42> Routing: from sestar.synchro.net: Closing Link: cvs.synchro.net (wkitty42)

Sep 15 10:04:21 <wkitty42> Routing: Auto-connecting to *.synchro.net

Sep 15 10:04:21 <wkitty42> Routing: Connected! Sending info...

Sep 15 10:04:21 <wkitty42> 0006 Accepted new connection: 71.95.196.34 port 6667

Sep 15 10:04:21 <wkitty42> JavaScript Background Load: /sbbs/exec/load/dnshelper.js

Sep 15 10:04:21 <wkitty42> Routing: Auto-connecting to *.synchro.net

Sep 15 10:04:21 <wkitty42> Routing: Connected! Sending info...

Sep 15 10:04:21 <wkitty42> 0008 Accepted new connection: 71.95.196.36 port 6667

Sep 15 10:04:21 <wkitty42> JavaScript Background Load: /sbbs/exec/load/dnshelper.js

[...]

Sep 15 10:21:09 <wkitty42> yeah, that's why i asked my question ;) i've seen vert having problems lately with such... not sure if that's because it is being run from services or not, though... i run mine from jsexec specifically to prevent it from bouncing all the time when i'm working on the board...

Sep 15 10:22:19 <wkitty42> so maybe that's why i don't see the problem that vert sees? does anyone else see the problem on their system? do they run from services or via jsexec?

----- snip -----


)\/(ark

---
þ Synchronet þ The SouthEast Star Mail HUB - SESTAR

Re: src/sbbs3/js_global.c
By: Rampage to Digital Man on Sat Sep 21 2019 11:38 am

Re: src/sbbs3/js_global.c
By: Digital Man to mark lewis on Sat Sep 21 2019 02:02:14

so did my questioning about the background loading of dnshelper.js assist in finding this problem?? if so, YAY!

I don't recall that being discussed. It just a shot in the dark that lead to some clues.

yeah, sorry, that was with my other account, wkitty42, on IRC on the 15th...

double spaced to try to prevent word wrapping from making dog's breakfast out of it... time stamps are UTC-0400...

----- snip -----

Sep 15 10:04:20 <wkitty42> why is dnshelper.js loaded by ircd.js multiple times? should it be "required" so it is loaded once and used for all? could this be one of the leaks being seen?

I don't recall seeing that. No, require() would not be of use there. Yes, the bg-load was the issue (not specific to dnshelper.js).


digital man

Synchronet "Real Fact" #43:
Synchronet added Baja/PCMS support with v2.00a (1994).
Norco, CA WX: 82.1øF, 45.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.403 1.404
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32349

Modified Files:
js_global.c
Log Message:
Resolve MSVC warnings:
src\sbbs3\js_global.c(3703): warning C4018: '<': signed/unsigned mismatch src\sbbs3\js_global.c(3761): warning C4018: '<': signed/unsigned mismatch src\sbbs3\js_global.c(3779): warning C4018: '<': signed/unsigned mismatch

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.404 1.405
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20519

Modified Files:
js_global.c
Log Message:
Document that mkpath() returns true if the path already exists.

ie: Does not return if the path was made or not.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 js_global.c 1.405 1.406
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20353

Modified Files:
js_global.c
Log Message:
When a server does a background load, this line would be logged to the terminal server (uck). Needs an lputs() callback or similar.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net